xen-ia64-devel

[Top] [All Lists]

RE: [Xen-ia64-devel] [RFC][PATCH] hypercall_preempt_check() and psr.i

from [Alex Williamson]

[Permanent Link][Original]

To:	"Tian, Kevin" <kevin.tian@xxxxxxxxx>
Subject:	RE: [Xen-ia64-devel] [RFC][PATCH] hypercall_preempt_check() and psr.i
From:	Alex Williamson <alex.williamson@xxxxxx>
Date:	Wed, 29 Mar 2006 11:55:18 -0700
Cc:	Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Wed, 29 Mar 2006 18:56:41 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<571ACEFD467F7749BC50E0A98C17CDD8094E7A22@pdsmsx403>
List-help:	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id:	Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post:	<mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	LOSL
References:	<571ACEFD467F7749BC50E0A98C17CDD8094E7A22@pdsmsx403>
Sender:	xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Wed, 2006-03-29 at 22:14 +0800, Tian, Kevin wrote:
> Hi, Isaku,
>       Seems we're shooting same issue by different way. In the beginning, 
> I also came up same simple approach as yours. However after more 
> thinking, I think it's better to tune xen/ia64 to adapt to common concept 
> where evtchn_upcall_mask is the flag whether events/interrupts can be 
> injected into guest. Or else we have to add similar #ifdef as yours time to 
> time, which especially only be observed when important bugs are tracked 
> down after many debugs.

   The simplicity and compact-ness of Isaku's patch is certainly
appealing.  What if instead of fixing this one case with a #ifdef we
were to something like this:

#define event_pending(v)                         \
    ((!!(v)->vcpu_info->evtchn_upcall_pending &  \
       !(v)->vcpu_info->evtchn_upcall_mask)) &&  \
      arch_event_pending(v))

x86:

#define arch_event_pending(v) (1)

ia64:

#define arch_event_pending(v) (PSCB(v, interrupt_delivery_enabled))

Thanks,

    Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] [RFC][PATCH] hypercall_preempt_check() and psr.i, Isaku Yamahata RE: [Xen-ia64-devel] [RFC][PATCH] hypercall_preempt_check() and psr.i, Tian, Kevin RE: [Xen-ia64-devel] [RFC][PATCH] hypercall_preempt_check() and psr.i, Alex Williamson <=

Previous by Date:	RE: [Xen-ia64-devel] [PATCH] access_reflection fix, Magenheimer, Dan (HP Labs Fort Collins)
Next by Date:	Re: [Xen-ia64-devel] [PATCH] make xen-mkbuildtree-pre robust a bit, Alex Williamson
Previous by Thread:	RE: [Xen-ia64-devel] [RFC][PATCH] hypercall_preempt_check() and psr.i, Tian, Kevin
Next by Thread:	[Xen-ia64-devel] [PATCH] RESEND: Enable hash vtlb on dom0&domU, Xu, Anthony
Indexes:	[Date] [Thread] [Top] [All Lists]