WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] [RFC] The "vcpu->arch.privregs" is doubly used

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [RFC] The "vcpu->arch.privregs" is doubly used
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Mon, 20 Mar 2006 17:44:04 +0900
Delivery-date: Mon, 20 Mar 2006 08:45:15 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I found the "vcpu->arch.privregs" being doubly used.
Please refer to the following functions.

 - alloc_vcpu_struct()          : xen/arch/ia64/xen/domain.c
 - vmx_final_setup_guest()      : xen/arch/ia64/vmx/vmx_init.c

I suggest the following patch. Please comment.

Best regards,
 Kan

diff -r 25003dd43a92 xen/arch/ia64/vmx/vmx_init.c
--- a/xen/arch/ia64/vmx/vmx_init.c      Fri Mar 17 15:37:28 2006 -0700
+++ b/xen/arch/ia64/vmx/vmx_init.c      Mon Mar 20 17:35:23 2006 +0900
@@ -261,6 +261,8 @@ vmx_final_setup_guest(struct vcpu *v)
 {
        vpd_t *vpd;
 
+       free_xenheap_pages(v->arch.privregs, get_order(sizeof(mapped_regs_t)));
+
        vpd = alloc_vpd();
        ASSERT(vpd);



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel