Re: [Xen-ia64-devel] [PATCH] XEN: Merge guest TR emulation

On Thu, 2006-03-09 at 14:07 +0800, Xu, Anthony wrote:
> This patch is intended to merge guest TR emulation both on VTIdomain
> and para-domain.

Hi Anthony,

   This seems to introduce a bunch of VCPU redefined warnings.  Also,
please check the formatting consistency around vcpu_get/set_rr().  There
seems to be a mix of spaces and tabs within the same function there.
I'd prefer that we at least keep consistent indentation within a
function for readability.  Thanks,

        Alex
-- 
Alex Williamson                             HP Linux & Open Source Lab

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] [PATCH] XEN: Merge guest TR emulation, Xu, Anthony Re: [Xen-ia64-devel] [PATCH] XEN: Merge guest TR emulation, Alex Williamson <=

Previous by Date:

RE: [Xen-ia64-devel] vIOSAPIC and IRQs delivery, Dong, Eddie

Next by Date:

[Xen-ia64-devel] Re: [Patch]: user process should not crash Xen., Alex Williamson

Previous by Thread:

[Xen-ia64-devel] [PATCH] XEN: Merge guest TR emulation, Xu, Anthony

Next by Thread:

[Xen-ia64-devel] CPL of linux, Tristan Gingold

Indexes:

[Date] [Thread] [Top] [All Lists]