WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] in_tpa is not SMP-safe

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Subject: [Xen-ia64-devel] in_tpa is not SMP-safe
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Tue, 7 Mar 2006 17:45:42 +0100
Delivery-date: Tue, 07 Mar 2006 16:42:23 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Hi,

the use of in_tpa is not SMP-safe:

[in vcpu.c:]
#if 1
// TEMPORARY PATCH for match_dtlb uses this, can be removed later
// FIXME SMP
int in_tpa = 0;
#endif

[vcpu_translate]
        if (/* is_data && */ vcpu_match_tr_entry(trp,address,rid)) {
                if (vcpu->domain==dom0 && !in_tpa) *pteval = trp->page_flags;
                else *pteval = vcpu->arch.dtlb_pte;
                *itir = trp->itir;
                dtlb_translate_count++;
                return IA64_NO_FAULT;
        }

[vcpu_tpa:]
        in_tpa = 1;
        fault = vcpu_translate(vcpu, vadr, 1, &pteval, &itir, &iha);
        in_tpa = 0;


Should we add a new parameter to vcpu_translate or change the is_data 
parameter to flags ?

BTW, I do not really understand it.  Why vcpu->arch.dtlb_pte can be wrong ?

Tristan.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-ia64-devel] in_tpa is not SMP-safe, Tristan Gingold <=