Re: [Xen-ia64-devel] [PATCH]Guarantee VTi guest can get correct frequency base

[Alex Williamson <alex.williamson@xxxxxx>]

On Mon, 2006-03-06 at 16:19 +0800, Zhang, Xiantao wrote:

>      PAL_CALL(result,PAL_FREQ_BASE, 0, 0, 0);
> +    if(result.v0 == 0){
> //PAL_FREQ_BASE may not be implemented in some platforms, call SAL
> instead.

   Should this be checking result.status == -1 (unimplemented)?

> +        SAL_CALL(isrv, SAL_FREQ_BASE, 
> +                SAL_FREQ_BASE_PLATFORM, 0, 0, 0, 0, 0, 0);

   I'm not sure I understand why pal_freq_base() must return something.
Shouldn't any VMs trying to call PAL_FREQ_BASE be prepared for an
unimplemented return and then try SAL_FREQ_BASE instead?  Thanks,

        Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel