Re: [Xen-ia64-devel] [PATCH]redefine raw_smp_processor_id()

Le Mercredi 22 Février 2006 06:34, Xu, Anthony a écrit :
> There are two definitions of raw_smp_processor_id()
> One is in file xen/include/asm-ia64/linux/asm/smp.h
>       #define raw_smp_processor_id() (current_thread_info()->cpu)
> The other is in file /xen/include/asm-ia64/config.h
>       #define raw_smp_processor_id()   current->processor
> In fact, the first one takes effect, that's not correct.
>
> I think if most of warning issues has been fixed, this redefinition
> message will be outstanding, and it will not cost me much time to fix
> this issue.
>
> I suggest if someone in community has had this kind of patch to remove
> some warning messages, please send out your patch, which will definitely
> mitigate developers' debugging effort.
I 100% agree.  Maybe we should do a warning-fix session ?

BTW, you should move smp.h from linux/asm to linux-xen/asm.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-ia64-devel] [Patch] iosapic virtualization again, Tristan Gingold

Next by Date:

RE: [Xen-ia64-devel] Weekly benchmark results [2/3rd week], Akio Takebe

Previous by Thread:

[Xen-ia64-devel] [PATCH]redefine raw_smp_processor_id(), Xu, Anthony

Next by Thread:

Re: [Xen-ia64-devel] [PATCH]redefine raw_smp_processor_id(), Akio Takebe

Indexes:

[Date] [Thread] [Top] [All Lists]