WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-devel] RE: [Xen-ia64-devel] cset 8690 blk driver regression

To: "Williamson, Alex (Linux Kernel Dev)" <alex.williamson@xxxxxx>, <sos22@xxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] RE: [Xen-ia64-devel] cset 8690 blk driver regression
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Tue, 31 Jan 2006 12:11:51 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 31 Jan 2006 20:21:45 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYl4SdSNvc8fxErSMGcuHG4b5UXvgAwBo1g
Thread-topic: [Xen-ia64-devel] cset 8690 blk driver regression
I can confirm this is broken on ia64 and that with this
reverted, with the xenlinux/ia64 subarch changes (just
checked in by Christian) and with the set_pfn_from_mfn
patch I posted an hour ago, Xen/ia64 is ready for 3.0.1.
(Assuming of course something else doesn't get broken
between now and then :-)

So... we need to get this fixed prior to 3.0.1!

To fix it so that it works on x86 (shadow and non-shadow)
and ia64, perhaps a macro call could be substituted for
the three removed lines and define'd differently for each
arch in asm/shadow.h?

Thanks,
Dan

> -----Original Message-----
> From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf 
> Of Williamson, Alex (Linux Kernel Dev)
> Sent: Monday, January 30, 2006 2:08 PM
> To: sos22@xxxxxxxxx
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-ia64-devel] cset 8690 blk driver regression
> 
> Hi Steven,
> 
>   I'm seeing a regression on ia64 with this chunk of cset 8690:
> 
> --- a/xen/common/grant_table.c        Fri Jan 27 20:38:55 2006
> +++ b/xen/common/grant_table.c        Fri Jan 27 20:57:07 2006
> @@ -522,9 +522,7 @@
>          ASSERT(d->grant_table != NULL);
>          (void)put_user(GNTST_okay, &uop->status);
>          for ( i = 0; i < op.nr_frames; i++ ) {
> -            mfn = gnttab_shared_mfn(d, d->grant_table, i);
> -            if (shadow_mode_translate(d))
> -                mfn = __mfn_to_gpfn(d, mfn);
> +            mfn = __mfn_to_gpfn(d, gnttab_shared_mfn(d, 
> d->grant_table, i));
>              (void)put_user(mfn, &op.frame_list[i]);
>          }
>      }
> 
> With this chunk, my domU no longer finds it's block device 
> and fails to
> boot:
> 
> VFS: Cannot open root device "hda1" or unknown-block(0,0)
> Please append a correct "root=" boot option
> Kernel panic - not syncing: VFS: Unable to mount root fs on
> unknown-block(0,0)
> 
> Everything appears fine if I revert it.  Is this an 
> intentional change?
> It appears to be more of a functional change than the check-in comment
> for this changeset would imply.  Thanks,
> 
>       Alex
> 
> -- 
> Alex Williamson                             HP Linux & Open Source Lab
> 
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>