| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.
|
To: |
Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno. |
|
From: |
Amit Shah <amit.shah@xxxxxxxxxx> |
|
Date: |
Fri, 18 Nov 2011 00:39:20 +0530 |
|
Cc: |
Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxx>, Miche Baker-Harvey <miche@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Anton Blanchard <anton@xxxxxxxxx>, Mike Waychison <mikew@xxxxxxxxxx>, ppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>, Eric Northrup <digitaleric@xxxxxxxxxx> |
|
Delivery-date: |
Thu, 17 Nov 2011 11:10:58 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<877h37qo5z.fsf@xxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20111108214452.28884.14840.stgit@xxxxxxxxxxxxxxxxxxxxxxxxx> <20111108214458.28884.86759.stgit@xxxxxxxxxxxxxxxxxxxxxxxxx> <877h37qo5z.fsf@xxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Fri) 11 Nov 2011 [14:57:20], Rusty Russell wrote:
> On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey <miche@xxxxxxxxxx>
> wrote:
> > Some modifications of vtermno were not done under the spinlock.
> >
> > Moved assignment from vtermno and increment of vtermno together,
> > putting both under the spinlock. Revert vtermno on failure.
> >
> > Signed-off-by: Miche Baker-Harvey <miche@xxxxxxxxxx>
>
> Does it matter? It's normal not to lock in a function called
> "init_XXX", since it's not exposed yet.
>
> Or is it?
Slight misnomer, I suppose.
We do this init_console_port() as part of add_port() if the port is a
console port. Should it be named 'mark_console_port()'? Dunno,
doesn't sound like the right name. init fits closest.
Amit
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home