WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Xen-users] Xen 4.1.1 crash when manipulating cpupoo

To: andrewpitman@xxxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-users] Xen 4.1.1 crash when manipulating cpupools.
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Mon, 14 Nov 2011 10:58:18 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-users@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Nov 2011 02:02:47 -0800
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1321264699; x=1352800699; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to; bh=eXSDlcK7wG5YSrtpWM+0gbugT+fFPGalhUMllN87FNg=; b=KUlC50hwEwf5lWKLZltT+FV1bjubDxJcewyq1vqfKZx+AKcfWNoPnOjg TH5hNdqAT+ZemZeX3XXROqyDDAfkfYLXFXU99zNUWjZO2g++UcGMs6GZ1 6wv8cfRNy2Eowg1MkHK8Q30G09awxYB2+99w10pI4TTMiEfslvcsn59xf oHesThIeUh7866erWXaDY3+n4lEKfjKC5RWkSsdLeBQVfyRUb1j+TCWT8 jRt1CMqLbzPGFpsPGB8S5u7HTWcmo;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=f3qdoQHXv/p79qQVCqB7c0e/TB4G3MqU3OIgJG76w7Ht8riN5xyxLvr3 1qcxJjty9ud1YzDgPu+p4BtdOF136YisJNOC/nUBaUvlgpPHQXbA62t9U jvFA1STA/RptHizwQ7B4eSK9bXWzZVHrya1J8uawWl/8Gg+nC+1Xs6r70 a6N+h8FgG5LaJNvXj8VGoCkLV5woGd3R4gJYnlL3Jew8qcSujX5mLqxDc 5WD8xM7cCCVshEvBM2zsF8dc+UrSN;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EC0DD6A.7040007@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <553832861.1721802.1321046283027.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4EC0DD6A.7040007@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15
On 11/14/2011 10:20 AM, Juergen Gross wrote:
On 11/11/2011 10:18 PM, andrewpitman@xxxxxxxxxxx wrote:
Juergen,

It doesn't look like this has been fixed.  I managed to get my 4.1.2 server to crash when setting the weight of Domain-0 (running in Pool-0 using credit2) and again when moving some cpus into a new cpupool which was set up to use the credit2 scheduler.

Yeah, I could reproduce your problems on my machine.

George, I see two problems in credit2:

- when setting the weight of dom0, vcpu_schedule_lock_irq(current) will be
  taken in sched_adjust() of schedule.c and again in csched_dom_cntl() of
  sched_credit2.c resulting in a deadlock.

- removing a cpu from a cpupool seems not to work for credit2. I removed all
  but cpu 0 from Pool-0 and the dom0 vcpus were all active on cpus 1-3. It
  took some time until they moved to cpu 0 (verified via 'r' hotkey on the
  xen console).

IMO the problem is choose_cpu() not using CSCHED_CPUONLINE(). The comment

        /* Leave it where it is for now.  When we actually pay attention
         * to affinity we'll have to figure something out... */

suggests the solution isn't too easy...


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel