WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "annie.li@xxxxxxxxxx" <annie.li@xxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture
From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
Date: Wed, 9 Nov 2011 14:56:42 +0000
Accept-language: en-US
Acceptlanguage: en-US
Cc: "kurt.hackel@xxxxxxxxxx" <kurt.hackel@xxxxxxxxxx>, "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date: Wed, 09 Nov 2011 07:03:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20111109144922.GC8410@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4EBA35D3.3020506@xxxxxxxxxx> <1320826490-29362-1-git-send-email-annie.li@xxxxxxxxxx> <291EDFCB1E9E224A99088639C4762022B4543AB1BD@xxxxxxxxxxxxxxxxxxxxxxxxx> <20111109144922.GC8410@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acye73UbdvaN+on5SqWNNgKu2cVKewAACtWw
Thread-topic: [PATCH 1/3] Introducing grant table V2 stucture
I'd be happy with 'addr' or 'opaque' or somesuch if 'raw' is distasteful.

  Paul

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@xxxxxxxxxx]
> Sent: 09 November 2011 14:49
> To: Paul Durrant
> Cc: annie.li@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; jeremy@xxxxxxxx; kurt.hackel@xxxxxxxxxx
> Subject: Re: [PATCH 1/3] Introducing grant table V2 stucture
> 
> On Wed, Nov 09, 2011 at 11:11:22AM +0000, Paul Durrant wrote:
> > Annie,
> >
> >   Comments inline below...
> >
> > > -----Original Message-----
> > [snip]
> > > -static struct grant_entry *shared;
> > > +static union {
> > > + struct grant_entry_v1 *v1;
> > > + void *ring_addr;
> > > +} shared;
> > > +
> >
> > 'ring_addr' seems like the wrong name here; how about 'raw'?
> 
> Or 'ring'. I asked Annie to change it from 'raw' to something else
> and the first thing that came in my mind was 'ring_addr'. But this
> does not point to a ring, so the 'ring' part is wrong.
> 
> Point here is to make it descriptive. 'raw' does not carry meaning
> of _what_ it is suppose to do.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel