WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 4 of 4] xenpaging: initial libxl support

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 4 of 4] xenpaging: initial libxl support
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Mon, 7 Nov 2011 13:55:35 +0100
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date: Mon, 07 Nov 2011 04:56:53 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1320670554; l=1328; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=PqfbRs2qxe8PWkgszjHypXObgbE=; b=Cgylg1XYshj9+upX8yOf/nag1RDtHALbtkJLXEfp3cxQTO1kiFukEuUykLwoMmvVLyi 0FbjcMgUXXDb3bqhwdhVwAtmkJ0otL65xrnAWExVx4JQq4c9OIU44tC6KrukWloC4c1x4 lId1PWfyCVDZda7OMiS2rsBilGFgGLI4ZqY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1111071053160.3519@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1320245136@xxxxxxxxxxxx> <ab5406a5b1d01e3828f0.1320245140@xxxxxxxxxxxx> <alpine.DEB.2.00.1111071053160.3519@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21.rev5535 (2011-07-01)
On Mon, Nov 07, Stefano Stabellini wrote:

> I think that using tot_memkb to store the actual memory target and then
> checking whether is 0 to detect if paging is active/inactive is
> confusing.

tot_memkb is only set when it was specified in the config file, and
perhaps later when a suitable xl mem-FOO command and a related watch on
the targer-tot_pages node is added.

> If tot_memkb is the pod target of the domain, we should be coherent and
> set it equal to target_memkb when paging is inactive.

So far PoD and paging are unrelated and mean different things.
I think the difference between max_memkb and tot_memkb could be the
trigger to start paging.

> >   === Domain memory breakdown: PV guests ==================================
> > 
> > diff -r a51d4fab351d -r ab5406a5b1d0 tools/libxl/libxl_types.idl
> > --- a/tools/libxl/libxl_types.idl
> > +++ b/tools/libxl/libxl_types.idl
> > @@ -157,6 +157,7 @@ libxl_domain_build_info = Struct("domain
> >      ("tsc_mode",        integer),
> >      ("max_memkb",       uint32),
> >      ("target_memkb",    uint32),
> > +    ("tot_memkb",       uint32),
> >      ("video_memkb",     uint32),
> >      ("shadow_memkb",    uint32),
> >      ("disable_migrate", bool),
> 
> I would like a comment somewhere of what tot_memkb is supposed to
> represent.

Yes, sorry, docu is lacking in that change.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel