WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Regression: patch " hvc_console: display printk messages

To: Greg KH <gregkh@xxxxxxx>
Subject: [Xen-devel] Re: Regression: patch " hvc_console: display printk messages on console." causing infinite loop with 3.2-rc0 + Xen.
From: Miche Baker-Harvey <miche@xxxxxxxxxx>
Date: Thu, 27 Oct 2011 07:45:07 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 28 Oct 2011 09:14:18 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1319726709; bh=dALNkkuHm9vM4cbl/ikGbrvUqSA=; h=MIME-Version:In-Reply-To:References:Date:Message-ID:Subject:From: To:Cc:Content-Type; b=uTuRuirF6hutSnXJY5ffzQ8seYaS45vDPfGzwFm+BWVKjq77fwchMukXH6kCIAZVG YSHmqkXwn7lCrx1YG075A==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record; bh=r80JJmhoeFdR7YfuuMnswGq8tfJNIhT9gmIBn9+uG94=; b=tNMQk+gSrDa/sv2igeEr1ZF500RBZt5zdzF1+907N5gGX/GeTkbeMBk1ODSG2rwwnB CICE+kY7Ktt7lyN7L8LA==
Domainkey-signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:date: message-id:subject:from:to:cc:content-type:x-system-of-record; b=DRpmjVEmc2wnPvuxGQb6r5QUCWNMhqRz8eP/bJb0K9WCyCsIeFtJ1g5WH2lCZZOhm zAX/5kHYqNRSFpBB4t32w==
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20111027054806.GA1377@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20111027053007.GA32765@xxxxxxxxxxxxxxxxxxx> <20111027054806.GA1377@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Bummer.  Sorry about that. 

Konrad, could you give me a hand figuring out what's up with this - I'm not running Zen here.  (If there's a test suite I could have run, mea culpa, and please point me in the right direction.)

The "console [hvc0] enabled" message is coming from register_console() in printk.c, and it doesn't have any loops.
It's called from hvc_console_init(), hvc_instantiate(), and hvc_alloc(), none of which have loops.  The call in hvc_alloc() is the one I added, so either I've inadvertently made one of the other two repeat (I'm guestting hvc_instantiate() is the one you're using), or you're infinitely calling hvc_alloc().  There's a calls to hvc_alloc() in hvc_xen.c::xen_hvc_init(), and in init_port_console() in virtio_console.c, but again, no loops.  Similarly for hvc_instantiate().

So, could I trouble you to put a breakpoint in register_console() and send me the stack?

Thanks,
Miche

On Wed, Oct 26, 2011 at 10:48 PM, Greg KH <gregkh@xxxxxxx> wrote:
On Thu, Oct 27, 2011 at 01:30:08AM -0400, Konrad Rzeszutek Wilk wrote:
> Hey Miche.
>
> The git commit 361162459f62dc0826b82c9690a741a940f457f0:
>
>     hvc_console: display printk messages on console.
>
> is causing an infinite loop when booting Linux under Xen, as so:
>
> [    2.382984] console [hvc0] enabled
> [    2.382984] console [hvc0] enabled
> [    2.382984] console [hvc0] enabled
> [    2.382984] console [hvc0] enabled
> [    2.382984] console [hvc0] enabled
> [    2.382984] console [hvc0] enabled
> ..
>
> (see attached file titled bad.log)
>
> If I use Linus's latest git tree and revert your patch I get the kernel
> to bootup (see good.log file),

Ick, not good, thanks for letting us know.

Miche, want me to just revert this, or do you think you can fix it?

thanks,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>