 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --ena
| To: | Peter Maydell <peter.maydell@xxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough. |
| From: | Anthony PERARD <anthony.perard@xxxxxxxxxx> |
| Date: | Wed, 19 Oct 2011 16:01:41 +0100 |
| Cc: | Alex Williamson <alex.williamson@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> |
| Delivery-date: | Wed, 19 Oct 2011 08:09:46 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=VsMrxrk05Czgr5lGZQjphu53IyKcK0UaMZQgjR+oLz4=; b=MGTIDwdgcnlBwQs/3J7vT3N6YtoaD6oiPY/FmylDFHZpfNa8hj1CPuGwCdr8SP++xH 8lPgHheLGt8PBiUc6FqksfjLGN3iqT86yPlewZ9HVSZBjtudnLtpdCgbAkCGbURHWjDc jJTPdZnWuyjDMnd8YHasTQ2xC8y+fJGdPUR8Q= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <CAFEAcA_jX8t_8UtKOodXAOD-Arz2WPX71vWrLBZwT_4ODG_d0g@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <1319032613-10560-1-git-send-email-anthony.perard@xxxxxxxxxx> <1319032613-10560-2-git-send-email-anthony.perard@xxxxxxxxxx> <CAFEAcA_jX8t_8UtKOodXAOD-Arz2WPX71vWrLBZwT_4ODG_d0g@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Wed, Oct 19, 2011 at 15:48, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote: > On 19 October 2011 14:56, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote: >> +if test "$xen_pci_passthrough" != "no"; then >> + if test "$xen" = "yes" -a "$linux" = "yes"; then >> + xen_pci_passthrough=yes >> + else >> + if test "$xen_pci_passthrough" = "yes"; then >> + feature_not_found "Xen PCI Passthrough without Xen or not on linux" >> + fi >> + xen_pci_passthrough=no >> + fi >> +fi > > The -a flag to test is obsolete -- don't use it in new code. ok, I'll just replace it by "&& test" > This is a bit of a misuse of the feature_not_found function IMHO. > (Also, Linux needs a capital letter.) Yes, probably this message will be more useful: echo "ERROR: User requested feature Xen PCI Passthrough" echo "ERROR: but this feature require /sys from Linux" Thanks, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | Re: [Xen-devel] [PATCH 1/5] xen/netback: Use xenballooned pages for comms, Daniel De Graaf |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 1/5] xen/netback: Use xenballooned pages for comms, Ian Campbell |
| Previous by Thread: | [Xen-devel] Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough., Peter Maydell |
| Next by Thread: | [Xen-devel] Re: [PATCH V2 01/10] configure: Introduce --enable-xen-pci-passthrough., Stefano Stabellini |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
