WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries

To: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 17 Oct 2011 15:33:25 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 17 Oct 2011 07:34:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ae251a2f9490dfa98553.1318594610@loki>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <ae251a2f9490dfa98553.1318594610@loki>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Roger Pau Monne writes ("[Xen-devel] [PATCH] tools/build: append user includes 
and libraries at the end of the compile flags"):
> tools/build: append user includes and libraries at the end of the compile 
> flags
> 
> Appending EXTRA_LIB and EXTRA_INCLUDES to LDFLAGS and CFLAGS respectively 
> made the compiler and linker choose the libraries and header files present in 
> the user's local folder rather than the ones present in the Xen build folder. 
> EXTRA_LIB and EXTRA_INCLUDES are now appended at the end to prevent this.

This looks reasonable to me, although the commit message still talks
about EXTRA_*.  Is everyone happy with the name
USER_{LDFLAGS,CFLAGS} ?

I'll give people a few days to comment, but I'm inclined to apply this
one.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel