WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: update nic list API to use common device

To: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: update nic list API to use common device API style
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 5 Oct 2011 14:10:44 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 05 Oct 2011 06:11:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <e94763a6bd3495cc95bd.1317818891@loki>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <cafd8b3f9e0c8bbf5c30.1317389599@xxxxxxxxxxxxxxxxxxxxx> <e94763a6bd3495cc95bd.1317818891@loki>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
(I assume everything but the following hunk was a mistake)

> diff -r 25db0629e338 -r e94763a6bd34 tools/libxl/Makefile
> --- a/tools/libxl/Makefile      Fri Sep 30 14:27:27 2011 +0100
> +++ b/tools/libxl/Makefile      Fri Sep 30 14:27:27 2011 +0100
> @@ -119,7 +119,7 @@ libxlutil.a: $(LIBXLU_OBJS)
>         $(AR) rcs libxlutil.a $^
> 
>  xl: $(XL_OBJS) libxlutil.so libxenlight.so
> -       $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) libxlutil.so $(LDLIBS_libxenlight) 
> $(LDLIBS_libxenctrl)
> +       $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) libxlutil.so libxenlight.so 
> $(LDLIBS_libxenlight) $(LDLIBS_libxenctrl)
> 
>  testidl: testidl.o libxlutil.so libxenlight.so
>         $(CC) $(LDFLAGS) -o $@ testidl.o libxlutil.so $(LDLIBS_libxenlight) 
> $(LDLIBS_libxenctrl)

LDLIBS_libxenlight already has -lxenlight in it. I guess this changes
works around you local addition LDFLAGS=-L/usr/xen42/lib?

I'm not sure what the right answer is here.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel