Re: [Xen-devel] [PATCH 03 of 24] xenpaging: use PERROR to print errno

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Oct 04, George Dunlap wrote:

> On Mon, Oct 3, 2011 at 4:54 PM, Olaf Hering <olaf@xxxxxxxxx> wrote:

> >     seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET);
> > +    if (seek_ret == -1)
> > +    {
> > +        ret = -errno;
> > +        goto err;
> > +    }
> 
> Wouldn't it be more idiomatic to make both this check and the other
> check in the function:
> * check for seek_ret < 0 (rather than -1)

The man page said its -1, now that I read it again it says (off_t)-1, so
my change above should be updated to comply with the man page.

> * make file_op() return -1
> * Let the caller read errno?  (Rather than returning -errno)?

Yes, I will change this in a new patch.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel