WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] AMD-IOMMU: remove dead variable references

To: Jan Beulich <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] AMD-IOMMU: remove dead variable references
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 04 Oct 2011 12:58:57 +0100
Cc:
Delivery-date: Tue, 04 Oct 2011 05:03:45 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=FiZhkLs+2C+J7/c63x1laCZ4GnlR+K2shAgm3rp7Khw=; b=IHl2m+vf4+HvdLpLGPKkjXDFQAXQIs8qTKd6+8WzwrjqPLkq26swJW0xPCswanDGqn 7ahqRWRiGbZelRMJEe0/X6Q9um6adP3S+UKMxqZg/3dHcD8Y1Psd1ZOPAcfhcTjBNTnW eq/WG8/JZOY1ubwdHU2p205eVmiwu4wqGzHzg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E8B0B70020000780005929A@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcyCjP7fU+tLwY1zu0GfjPsX2OTP1A==
Thread-topic: [Xen-devel] [PATCH] AMD-IOMMU: remove dead variable references
User-agent: Microsoft-Entourage/12.30.0.110427
On 04/10/2011 12:34, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> These got orphaned up by recent changes.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -26,9 +26,6 @@
>  #include <asm/amd-iommu.h>
>  #include <asm/hvm/svm/amd-iommu-proto.h>
>  
> -extern bool_t __read_mostly opt_irq_perdev_vector_map;
> -extern bool_t __read_mostly iommu_amd_perdev_vector_map;
> -
>  struct amd_iommu *find_iommu_for_device(int seg, int bdf)
>  {
>      struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(seg);
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -50,7 +50,6 @@ bool_t __read_mostly iommu_qinval = 1;
>  bool_t __read_mostly iommu_intremap = 1;
>  bool_t __read_mostly iommu_hap_pt_share = 1;
>  bool_t __read_mostly iommu_debug;
> -bool_t __read_mostly iommu_amd_perdev_vector_map = 1;
>  bool_t __read_mostly amd_iommu_perdev_intremap;
>  
>  static void __init parse_iommu_param(char *s)
> @@ -86,8 +85,6 @@ static void __init parse_iommu_param(cha
>              iommu_dom0_strict = 1;
>          else if ( !strcmp(s, "sharept") )
>              iommu_hap_pt_share = 1;
> -        else if ( !strcmp(s, "no-perdev-vector-map") )
> -            iommu_amd_perdev_vector_map = 0;
>  
>          s = ss + 1;
>      } while ( ss );
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>