WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1 of 7] [OCAML] Rename the ocamlfind packages

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1 of 7] [OCAML] Rename the ocamlfind packages
From: Jonathan Ludlam <Jonathan.Ludlam@xxxxxxxxxxxxx>
Date: Fri, 30 Sep 2011 13:19:26 +0100
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 30 Sep 2011 05:20:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317368531.26672.203.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1317331042@xxxxxxxxxxxxxxxxxxxxxxxxxx> <c5df5f625ee2a0339b2a.1317331043@xxxxxxxxxxxxxxxxxxxxxxxxxx> <1317368531.26672.203.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acx/azJKAAIm66PhSdW/7fu+AvBqCQ==
Thread-topic: [Xen-devel] [PATCH 1 of 7] [OCAML] Rename the ocamlfind packages
On 30 Sep 2011, at 08:42, Ian Campbell wrote:

> On Thu, 2011-09-29 at 22:17 +0100, Jon Ludlam wrote:
>> ocamlfind does not support namespaces, so to avoid
>> name clashes the ocamlfind package names have been
>> changed. Note that this does not change the names
>> of the actual modules themselves.
> 
> So you do "ocamlfind xenbus" in your code but subsequently "import" xl.*
> (forgive my lack of actual ocaml syntax)?
> 
> I'm happy with that if its acceptable practice in ocaml, but given it's
> "just" a sed invocation away should we bite the bullet and change the
> module name too?
> 

It's not uncommon, e.g. the 'threads' package allows the use of the Thread, 
Mutex, Condition, Event and ThreadUnix modules, but not a 'Threads' one. Having 
said that, for the single module packages it would be slightly odd. The only 
thing that stopped me is that what I did involves a change in the makefiles of 
any ocaml project using the libs, whereas a renaming of the modules would 
require changing a lot more code. Being a bit ambivalent about the two 
approaches, I picked the one that was less noisy, though I'm willing to be 
persuaded otherwise.

>> xb becomes xenbus, xc becomes xenctrl, xl becomes xenlight,
>> xs becomes xenstore, eventchn becomes xeneventchn.
> 
> The next patch removes uuid which by my count leaves just the mmap
> library, any plans for that one?
> 

We haven't quite figured out what to do with that one yet. It depends a little 
on whether anything else is using the module. More to follow :-)

Jon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel