WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH v6 1/5] Introduce git-checkout.sh

stefano.stabellini@xxxxxxxxxxxxx writes ("[Xen-devel] [PATCH v6 1/5] Introduce 
git-checkout.sh"):
> Introduce a script to perform git checkout on an external git tree; use
> git-checkout.sh in ioemu-dir-find.
...
> +#!/bin/sh
> +
> +TREE=$1
> +TAG=$2
> +DIR=$3

Missing
 - set -e
 - argument count check

> +if test \! -d $DIR-remote; then
> +     rm -rf $DIR-remote $DIR-remote.tmp;

Spurious semicolons.

>  distclean: subdirs-distclean
> -     rm -rf ioemu-dir ioemu-remote
> +     rm -rf ioemu-dir ioemu-dir-remote

Would it be too much to ask you not to rename this directory ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel