Re: [Xen-devel] [PATCH 6 of 9] xenpaging: add evict_pages functi

To:	George Dunlap <dunlapg@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 6 of 9] xenpaging: add evict_pages function
From:	Olaf Hering <olaf@xxxxxxxxx>
Date:	Thu, 15 Sep 2011 11:17:23 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date:	Thu, 15 Sep 2011 02:18:30 -0700
Dkim-signature:	v=1; a=rsa-sha1; c=relaxed/relaxed; t=1316078265; l=1094; s=domk; d=aepfle.de; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Subject:Cc:To:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=hOOK6yUYVvXqbiTY4U6mNdtYMO0=; b=D+Kc8sPSlb0EwqNgSYHQHWE45fxfMq8I+SIoO8KY57tm1vSoFASnDuwMb6TfQGech8L 7zpA2Y0CE3lxvqrIG/m117mj+vep226FGiHRt1ImotYGuzBOt3PWI3KB9it5j69ynomrM 5t4zlQEJBIufM32y+z5rKu80nZSczYjm/OY=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<CAFLBxZaPWFSEj_apLtEn=CiZHiep0RMNd6iz_Ypc8Ep2X_Qjhw@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<patchbomb.1316067388@xxxxxxxxxxxx> <3a3a5979b799d9488021.1316067394@xxxxxxxxxxxx> <1316074602.25935.4.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAFLBxZaPWFSEj_apLtEn=CiZHiep0RMNd6iz_Ypc8Ep2X_Qjhw@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.21.rev5535 (2011-07-01)

On Thu, Sep 15, George Dunlap wrote:

> On Thu, Sep 15, 2011 at 9:16 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Thu, 2011-09-15 at 02:16 -0400, Olaf Hering wrote:
> >> # HG changeset patch
> >> # User Olaf Hering <olaf@xxxxxxxxx>
> >> # Date 1316067230 -7200
> >> # Node ID 3a3a5979b799d948802183d10d65894ee84a872f
> >> # Parent  6beca8cbc2c92900859712f8738db17084bcebdb
> >> xenpaging: add evict_pages function
> >>
> >> Add new function to evict a couple of pages.
> >
> > Do you really mean "a couple" here? (that generally means exactly two).
> 
> LIterally "couple" means two, but at least in US idiom, "a couple of
> [foo]" means a small indeterminate number, usually 2-4.
> 
> In any case, a more precise description seems like a better idea -- it
> looks like it takes an argument for the number of pages to evict; and
> it's not adding a new function, it's pulling existing code into a
> function.  So, "Pull eviction loop into a function" would probably be
> a better description.


Thanks to both of you, I will improve the description.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 6 of 9] xenpaging: add evict_pages function