WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH V4 3/3] xen-blkback: discard requests handling in

To: Li Dongyang <lidongyang@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH V4 3/3] xen-blkback: discard requests handling in blkback driver
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 1 Sep 2011 11:28:26 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, owen.smith@xxxxxxxxxx, JBeulich@xxxxxxxxxx
Delivery-date: Thu, 01 Sep 2011 08:29:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7f85bb71f76deed2537438928fa8b6dafb6a51f8.1314872306.git.lidongyang@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <cover.1314872306.git.lidongyang@xxxxxxxxxx> <7f85bb71f76deed2537438928fa8b6dafb6a51f8.1314872306.git.lidongyang@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 01, 2011 at 06:39:10PM +0800, Li Dongyang wrote:
> Now blkback driver can handle the discard request from guest, we will
> forward the request to phy device if it really has discard support, or we'll
> punch a hole on the image file.

The description should read:

   xen-blkback: Implement discard requests handling
   
    If the backend device (or loopback file) supports discard requests then
    advertise it to the frontend via 'feature-discard'.

    Implementation wise - if the backend is 'phy' - use blkdev_issue_discard,
    while if it is 'file', then punch a hole in the image file.
    
    Signed-off-by: Li Dongyang <lidongyang@xxxxxxxxxx>
.. snip..
> +     if (err == -EOPNOTSUPP) {
> +             pr_debug(DRV_PFX "blkback: discard op failed, "
                          ^^^^^^^ - get rid of that.

The DRV_PFX already provides the 'xen-blkback' string.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel