WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] IRQ: manually EOI migrating line interrupts

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] IRQ: manually EOI migrating line interrupts
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 30 Aug 2011 15:38:53 +0100
Cc:
Delivery-date: Tue, 30 Aug 2011 07:39:49 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=6NV5D0J7w5tWKOobESlJGC5kELbM0i6M1ttIYxFsY4U=; b=x0sWMDLs3CaJG/GhGlFgAtr/O3QB2V8+hNJBo6ECXsfqyEc99izfqqxo9fSIQUP2Pc p2w3YVT3I7617wtznZI4S1s1O0K4qodmunOq0YMACtM8Tv0Ur8rx0qEcmIyQWoMduNkW qbTL36guH61rEd64vLHimatIYRrROj4qgi1Vs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E5CF393.10903@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcxnIooTqGMuMEhVSUWpN/Qz668eAw==
Thread-topic: [PATCH] IRQ: manually EOI migrating line interrupts
User-agent: Microsoft-Entourage/12.30.0.110427
On 30/08/2011 15:28, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:

>> @@ -1739,6 +1739,14 @@ static void end_level_ioapic_irq (unsign
>>   */
>>      i = IO_APIC_VECTOR(irq);
>>  
>> +    /* Manually EOI the old vector if we are moving to the new */
>> +    if ( vector && i != vector )
>> +    {
>> +        int ioapic;
>> +        for (ioapic = 0; ioapic < nr_ioapics; ioapic++)
>> +            io_apic_eoi(ioapic, i);
>> +    }
>> +

I don't know whether it's worth the effort, but we ought to be able to do
better than this and send EOI to exactly the correct IO-APIC. I think
irq=gsi here? And we should know the gsi_base of every IO-APIC, so we can
work out in fact which pin of which IO-APIC needs clobbering?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel