WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its w

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2011 16:10:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 25 Aug 2011 08:17:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <31687c9a9e3edfae7cf2.1313130830@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <31687c9a9e3edfae7cf2.1313130830@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Olaf Hering writes ("[Xen-devel] [PATCH] xenstored: allow guests to shutdown 
all of its watches using XS_RESET"):
> Add a new XS_RESET command to do the reset on behalf of the guest.

I'm afraid I still think this is wrong.

* The XS_RESET command as you have it takes too many arguments.  It
  should probably not take any arguments at all.

* You have failed to update the specification document which describes
  the xenstored protocol (in docs/misc/)

* Your XS_RESET command doesn't just delete watches and transactions.
  It also:
     - discards outstanding responses to earlier commands
     - discards potential incoming partial commands
     - resets the ring pointers
  I don't think any of these things are necessary.  If they are,
  please explain.  I think you should have your do_reset simply call
  conn_delete_all_watches and conn_delete_all_transactions.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel