WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] KEXEC: disable hpet legacy broadcasts earlier

To: Keir Fraser <keir.xen@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] KEXEC: disable hpet legacy broadcasts earlier
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Thu, 18 Aug 2011 14:48:15 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx >> \"xen-devel@xxxxxxxxxxxxxxxxxxx\"" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 18 Aug 2011 06:49:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CA72D678.1F680%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CA72D678.1F680%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11

On 18/08/11 14:47, Keir Fraser wrote:
> On 18/08/2011 14:31, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:
>
>> On x2apic machines which booted in xapic mode,
>> hpet_disable_legacy_broadcast() sends an event check IPI to all online
>> processors.  This leads to a protection fault as the genapic blindly
>> pokes x2apic MSRs while the local apic is in xapic mode.
>>
>> One option is to change genapic when we shut down the local apic, but
>> there are still problems with trying to IPI processors in the online
>> processor map which are actually sitting in NMI loops
>>
>> Another option is to have each CPU take itself out of the online CPU
>> map during the NMI shootdown.
>>
>> Realistically however, disabling hpet legacy broadcasts earlier in the
>> kexec path is the easiest fix to the problem.
> This for 4.1.2 as well I guess?

Yes please

~Andrew

>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>
>> diff -r fc2be6cb89ad -r dcb3ed7b7dbd xen/arch/x86/crash.c
>> --- a/xen/arch/x86/crash.c Tue Aug 16 15:05:55 2011 +0100
>> +++ b/xen/arch/x86/crash.c Thu Aug 18 14:30:32 2011 +0100
>> @@ -29,6 +29,7 @@
>>  #include <asm/io_apic.h>
>>  #include <xen/iommu.h>
>>  #include <xen/pci.h>
>> +#include <asm/hpet.h>
>>  
>>  static atomic_t waiting_for_crash_ipi;
>>  static unsigned int crashing_cpu;
>> @@ -61,6 +62,9 @@ static void nmi_shootdown_cpus(void)
>>  
>>      local_irq_disable();
>>  
>> +    if ( hpet_broadcast_is_available() )
>> +        hpet_disable_legacy_broadcast();
>> +
>>      crashing_cpu = smp_processor_id();
>>      local_irq_count(crashing_cpu) = 0;
>>  
>> diff -r fc2be6cb89ad -r dcb3ed7b7dbd xen/arch/x86/machine_kexec.c
>> --- a/xen/arch/x86/machine_kexec.c Tue Aug 16 15:05:55 2011 +0100
>> +++ b/xen/arch/x86/machine_kexec.c Thu Aug 18 14:30:32 2011 +0100
>> @@ -85,9 +85,6 @@ void machine_kexec(xen_kexec_image_t *im
>>          .limit = LAST_RESERVED_GDT_BYTE
>>      };
>>  
>> -    if ( hpet_broadcast_is_available() )
>> -        hpet_disable_legacy_broadcast();
>> -
>>      /* We are about to permenantly jump out of the Xen context into the 
>> kexec
>>       * purgatory code.  We really dont want to be still servicing interupts.
>>       */
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>