This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [RFC PATCH] libxl: basic virtio disk / nic configuration

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC PATCH] libxl: basic virtio disk / nic configuration support.
From: Wei Liu <liuw@xxxxxxxxx>
Date: Sat, 30 Jul 2011 10:40:23 +0800
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Fri, 29 Jul 2011 19:40:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1107281258100.12963@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1311818929.1800.21.camel@limbo> <alpine.DEB.2.00.1107281258100.12963@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Jul 28, 2011 at 02:05:08PM +0100, Stefano Stabellini wrote:
> I think you need to add a new field in libxl_device_disk to specify the
> protocol, something like libxl_disk_protocol, that can be:
> then parse_disk_config can be modified to distinguish xen disks from
> virtio disks and set the field accordingly.

Hmm... wait...

Adding this field is easy. But I don't know if I fully understand your

I am just about to modify the parser. But looking back your replay,
you are not suggesting adding configuration syntax support in config
file (sort of `disk=["...,protocol=virito"]`).

So essentially the new patch will be of no difference to the original
one. But one advantage is that your plan seems cleaner (not exposing
hacks to other functions).

Do I get your point?


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>