This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH V2] hvmloader: Fix FADT table for QEMU Upstream.

To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH V2] hvmloader: Fix FADT table for QEMU Upstream.
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 27 Jul 2011 23:28:33 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Tobias Geiger <tobias.geiger@xxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 27 Jul 2011 15:29:42 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=NbNWfMtvRl8lL8AxgVXx6Fa+30Wi8R/LUX1CRjQL18k=; b=Id0C/o4RJ4fnmPGsuSe3Gy2aTjyerqKb83LUc2bsPKHwGgrV8PyP1i/ulFZsPd6dvj qdBY+w+C3pmNqQUbJAjKkiy4jiXZyK2o0LoTdhhIOLu4aYfXMK5Vp0jpf/A/S5S+is05 EjpELKWke6UJyeebcBdVROE124d2jMm/yncKQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAJJyHjLv2ozT-c++N08rDk-0pDNkSXWvSNhoxNL_qSgZg3iE8w@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcxMrISevG990Q1XL06oyaZyH0XpRw==
Thread-topic: [Xen-devel] [PATCH V2] hvmloader: Fix FADT table for QEMU Upstream.
User-agent: Microsoft-Entourage/
On 27/07/2011 17:00, "Anthony PERARD" <anthony.perard@xxxxxxxxxx> wrote:

> On Tue, Jul 26, 2011 at 18:48, Keir Fraser <keir@xxxxxxx> wrote:
>> Thinking about this some more I wonder whether this will be correct for old
>> Qemu. Furthermore, we don't actually have a legacy/SMM component in our
>> virtual firmware, so advertising the enable/disable mechanism via
>> SMI_CMD_IOPORT is a bit pointless.
>> Could we instead dynamically handle this in in hvmloader's acpi-handling
>> code something like:
>>  if ( !SCI_EN ) // must be new qemu if so
> I just try that, and that works fine. So it's fine to me to do that
> instead of providing an IOPort that is not handle by the
> qemu-xen-legacy.

Send me your tested patch!


>> Or alternatively, we should at least gate the setting of those FADT fields
>> on such a check, it seems to me.

Xen-devel mailing list