This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] RE: [PATCH] [RFC] VT-d: always clean up dpci timers.

To: Keir Fraser <keir.xen@xxxxxxxxx>
Subject: Re: [Xen-devel] RE: [PATCH] [RFC] VT-d: always clean up dpci timers.
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Mon, 25 Jul 2011 16:04:35 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Delivery-date: Mon, 25 Jul 2011 08:05:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CA5340AF.1E7DB%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110725142120.GD8970@xxxxxxxxxxxxxxxxxxxxxxx> <CA5340AF.1E7DB%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
At 15:47 +0100 on 25 Jul (1311608879), Keir Fraser wrote:
> On 25/07/2011 15:21, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
> >> Could we make need_iommu(d) sticky? Being able to clear it doesn't seem an
> >> important case (such a domain is probably being torn down anyway) and
> >> clearly it can lead to fragility. The fact that presumably we'd end up 
> >> doing
> >> unnecessary IOMMU PT work for the remaining lifetime of the domain doesn't
> >> seem a major downside to me.
> > 
> > If you prefer it that way.  TBH I think I prefer the other way though:
> > things that gate on need_iommu() should be cleaned up by
> > iommu->teardown().
> Is your original patch still proposed as a valid alternative to this one?

Yes; I prefer the original. 


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list