This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PROPOSED REMOVAL] PV guest superpage mappings

To: Dave McCracken <dcm@xxxxxxxx>
Subject: Re: [Xen-devel] Re: [PROPOSED REMOVAL] PV guest superpage mappings
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 20 Jul 2011 17:27:14 +0100
Cc: Keir Fraser <keir.xen@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 20 Jul 2011 09:27:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201107201113.40313.dcm@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <CA4C6B79.1E3C9%keir.xen@xxxxxxxxx> <201107201113.40313.dcm@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-07-20 at 17:13 +0100, Dave McCracken wrote:
> On Wednesday, July 20, 2011, Keir Fraser wrote:
> > The PV superpage mapping feature has been in the hypervisor for a while
> > now, but I'm not away of any use of this feature by an upstream guest
> > kernel (e.g., and primarily of interest, pv_ops Linux). Am I mistaken, or
> > is anyone looking into or interested in this? If the feature is unused we
> > should remove it from the hypervisor in this development cycle, as it's
> > untested and is nothing more than a maintenance burden and security risk.
> > If the feature is only used by vendor patches, the hypervisor-side
> > implementation belongs in that vendor's patch queues too.
> I submitted a patch to use this feature to Jeremy for inclusion in the Linux 
> kernel tree back when it first went into the hypervisor.  I was under the 
> impression it was in his tree, and would eventually make its way into 
> mainline 
> Linux.

I can't see it in his 2.6.32.x branch, although it may be elsewhere --
there seems to be a hugetlb branch but I don't know if it is merged
anywhere (nor do I know the magic git runes to find out).

In general patches which were against a Xen branch (rather than
upstream) may or may not have gone upstream depending on how core they
were and how much work it would be to make them suitable for upstream
etc (i.e. you couldn't rely 100% on a maintainer doing that work for
you). More recently we've been trying to encourage contributors to
target upstream directly instead of Xen branches for this reason.

> I must admit I moved on to other projects and did not follow it carefully.  
> What is the current path for Xen-specific patches to be included in Linux 
> mainline?

We need patches against a recent upstream kernel to be posted upstream
and reviewed etc. Once upstream review gives the all clear then a Xen
maintainer can queue them for the next merge window.

Hope that helps.


> This feature is important for hugepages to work well in a Xen guest.
> Dave McCracken
> Oracle Corp.
> dave.mccracken@xxxxxxxxxx
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list