[Xen-devel] Re: [PATCH, v2] libxl: sane disk backend selection and validation

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Wed, 2011-07-06 at 17:06 +0100, Ian Jackson wrote:
> diff -r d5dfaa568441 tools/libxl/libxl_device.c
> --- a/tools/libxl/libxl_device.c        Wed Jul 06 16:32:16 2011 +0100
> +++ b/tools/libxl/libxl_device.c        Wed Jul 06 17:03:06 2011 +0100
> @@ -116,6 +116,122 @@ retry_transaction:
>      rc = 0;
>  out:
>      return rc;
> +}
> +
> +typedef struct {
> +    libxl__gc *gc;
> +    libxl_device_disk *disk;
> +    struct stat stab;
> +} disk_try_backend_args;
> +
> +static int disk_try_backend(disk_try_backend_args *a,
> +                            libxl_disk_backend backend) { 

I just noticed this, and out of curiosity rather than thinking it should
change, is there a reason to avoid returning enum types for functions?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel