This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xencommons for NetBSD

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xencommons for NetBSD
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Fri, 15 Jul 2011 13:27:38 +0200
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 15 Jul 2011 04:28:30 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=SV9HspYKu9zDyfk46ZbkGmXV7EZTyOExVr47WKi/pkk=; b=cBwjEKxs+bhhbKR+Sbk0I58iTzt1UQd3MyANf91KpLOHVvgtR5rxkbPdpRcZe0Rmiy qNZxeq2Es4GeKkACxGUGYJEZkApw0vGOUyJ6Pj3/x8E5f8JQHhvX4tLX6x13oFb4Bcne /vChiGASQY+8ysA11rAXcgA/rvkaZiOfkqs5I=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1310724488.634.577.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CAPLaKK7siKth90wyjh465CVnmbDhFMZs3tLe_=fhuOjy2CmANQ@xxxxxxxxxxxxxx> <1310716893.634.552.camel@xxxxxxxxxxxxxxxxxxxxxx> <4E200171.5080700@xxxxxxx> <1310721214.634.561.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK5vbmF2GdDM1xz3R7-5+OMVTomaUv5zey0oYob=kVsDdg@xxxxxxxxxxxxxx> <1310722858.634.573.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK4dLuUfjsxPohcArTRV+eV6RU2ARqAHGkyy6bZL_c2BWQ@xxxxxxxxxxxxxx> <1310724488.634.577.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Another one, used -n instead of -z when testing the presence of
XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
shell init scripts.

Regards, Roger.

2011/7/15 Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>:
> On Fri, 2011-07-15 at 10:55 +0100, Roger Pau Monné wrote:
>> Just a minor fix, &>/dev/null used with rm puts the process in the
>> background, so xenstore might be started before the database was
>> cleaned.
> Oh right, because &>/dev/null is a bash-ism.
>> Regards, Roger.
>> 2011/7/15 Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>:
>> > On Fri, 2011-07-15 at 10:18 +0100, Roger Pau Monné wrote:
>> >> Thanks for the comments, here is the new patch, changed the commit
>> >> message and used the method found on Linux script to wait for xenstore
>> >> to come up.
>> >
>> > Looks good to me in the general sense, although I can't comment on the
>> > NetBSD specifics.
>> >
>> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> >
>> >
>> >

Attachment: patch-xencommons
Description: Binary data

Xen-devel mailing list