WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 1/3] xen-blkfront: Drop name and minor adjustment

To: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1/3] xen-blkfront: Drop name and minor adjustments for emulated scsi devices
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 14 Jul 2011 18:32:52 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano
Delivery-date: Thu, 14 Jul 2011 10:28:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1310650222-7293-1-git-send-email-stefan.bader@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4E1EEEA1.9050102@xxxxxxxxxxxxx> <1310650222-7293-1-git-send-email-stefan.bader@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 14 Jul 2011, Stefan Bader wrote:
> These were intended to avoid the namespace clash when representing
> emulated IDE and SCSI devices. However that seems to confuse users
> more than expected (a disk defined as sda becomes xvde).
> So for now go back to the scheme which does no adjustments. This
> will break when mixing IDE and SCSI names in the configuration of
> guests but should be by now expected.

This patch is fine by me.


> 
> Signed-off-by: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
> ---
>  drivers/block/xen-blkfront.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 2112822..a41530f 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -125,8 +125,8 @@ static DEFINE_SPINLOCK(minor_lock);
>  #define BLKIF_MINOR_EXT(dev) ((dev)&(~EXTENDED))
>  #define EMULATED_HD_DISK_MINOR_OFFSET (0)
>  #define EMULATED_HD_DISK_NAME_OFFSET (EMULATED_HD_DISK_MINOR_OFFSET / 256)
> -#define EMULATED_SD_DISK_MINOR_OFFSET (EMULATED_HD_DISK_MINOR_OFFSET + (4 * 
> 16))
> -#define EMULATED_SD_DISK_NAME_OFFSET (EMULATED_HD_DISK_NAME_OFFSET + 4)
> +#define EMULATED_SD_DISK_MINOR_OFFSET (0)
> +#define EMULATED_SD_DISK_NAME_OFFSET (EMULATED_SD_DISK_MINOR_OFFSET / 256)
>  
>  #define DEV_NAME     "xvd"   /* name in /dev */
>  
> -- 
> 1.7.4.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>