This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxc: set CPUID topology leaf as unsupported fo

To: Keir Fraser <keir.xen@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxc: set CPUID topology leaf as unsupported for PV guests
From: David Vrabel <david.vrabel@xxxxxxxxxx>
Date: Thu, 14 Jul 2011 15:25:57 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 14 Jul 2011 07:26:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CA44AE04.1DDBE%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CA44AE04.1DDBE%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110516 Thunderbird/3.1.10
On 14/07/11 14:30, Keir Fraser wrote:
> On 14/07/2011 12:50, "David Vrabel" <david.vrabel@xxxxxxxxxx> wrote:
>> libxc: set CPUID topology leaf as unsupported for PV guests
>> The result of a CPUID Extended Topology Enumeration leaf for PV guests
>> is invalid as the level in ECX is ignored.  This can cause some guests
>> to loop endlessly when trying to enumerate the topology.
>> Since the physical topology isn't useful to PV guests set the topology
>> leaf as unsupported.
> For future reference, you also need to modify
> xen/arch/x86/traps.c:pv_cpuid(), for dom0.

Looking at the code it looks like dom0 would at least see valid data for
the the topology leaf.  But I guess the info makes no sense to dom0 as
well as domU guests.  Patch sent if you've not already fixed it up.


Xen-devel mailing list