This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: xen-blkfront: Don't send closing notification to backend

To: Joe Jin <joe.jin@xxxxxxxxxx>, Jens Axboe <jaxboe@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: xen-blkfront: Don't send closing notification to backend in blkfront_closing()
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Tue, 12 Jul 2011 11:04:09 -0400
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Kurt C Hackel <KURT.HACKEL@xxxxxxxxxx>, Greg Marsden <greg.marsden@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, annie.li@xxxxxxxxxx, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jens Axboe <jaxboe@xxxxxxxxxxxx>, Daniel Stodden <daniel.stodden@xxxxxxxxxx>
Delivery-date: Tue, 12 Jul 2011 08:08:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E1BBFFD.7030900@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4E16AE55.50500@xxxxxxxxxx> <20110708160414.GA30120@xxxxxxxxxxxx> <4E17A01F.8060505@xxxxxxxxxx> <20110709131153.GA25916@xxxxxxxxxxxx> <4E1BBFFD.7030900@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
> without the patch, after detach the device by xm block-detach timeout also 
> umount hang in guest.
> with my patch, xm block-detach timeout in Dom0, umount in guest worked!

Ah, I failed to spot you did the unmount after the timeout. I tried to do the 
umount after
forcing the block-detach. [and testing confirms your patch working properly]

Looks good to me - with the only exception that the description needs to have 
'xm block-attach'
and 'xm block-detach' - please change that and resubmit and attach

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
CC: stable@xxxxxxxxxx

and make sure to have Jens in the 'To:' header.


Are you OK picking the amended patch (shortly to be posted) for 3.0-rc7?

Xen-devel mailing list