This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools/pygrub: fix solaris kernel sniff

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/pygrub: fix solaris kernel sniff
From: Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>
Date: Fri, 08 Jul 2011 14:45:04 -0400
Cc: kurt.hackel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, frank.che@xxxxxxxxxx
Delivery-date: Fri, 08 Jul 2011 11:46:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19991.15210.345950.186857@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <b579db4d7232b6541cdb.1310098777@xxxxxxxxxxxxxxxxxxxxx> <19991.15210.345950.186857@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7
On 07/08/2011 01:16 PM, Ian Jackson wrote:
> Zhigang Wang writes ("[Xen-devel] [PATCH] tools/pygrub: fix solaris kernel 
> sniff"):
>> tools/pygrub: fix solaris kernel sniff
>> Solaris 11 build 163+ removes '/platform/i86xpv/kernel/unix' and only the
>> 64-bit PV kernel file '/platform/i86xpv/kernel/amd64/unix' exists.
> Thanks but I'm not sure this is right.
> Previously, if none of the Solaris files in /platform exist, this code
> would unconditionally exit.
> Now you have moved the relevant return inside the
>    if not cfg["kernel"]:
> so that on a non-Solaris platform if cfg["kernel"] is not set we will
> always do the "Unpleasant" tweaks.
> I don't think that's correct.
> Ian.
Yes. I agree.

What about attached patch?


Attachment: xen-pygrub-fix-solaris-kernel-sniff
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>