WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH v2] xen_console: support the new extended xen

To: Peter Maydell <peter.maydell@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH v2] xen_console: support the new extended xenstore protocol
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 28 Jun 2011 16:06:22 +0100
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, "agraf@xxxxxxx" <agraf@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 28 Jun 2011 08:07:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTi=px9xd62yT7OBtMUvF--FQkXfVpg@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1309272956-6221-1-git-send-email-stefano.stabellini@xxxxxxxxxxxxx> <BANLkTi=px9xd62yT7OBtMUvF--FQkXfVpg@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2011-06-28 at 16:02 +0100, Peter Maydell wrote:
> On 28 June 2011 15:55,  <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > +    xs = xs_daemon_open();
> > +    if (xs == NULL) {
> > +        fprintf(stderr, "Could not contact XenStore\n");
> > +        goto out;
> > +    }
> 
> > +out:
> > +    free(path);
> > +    xs_daemon_close(xs);
> 
> Google suggests xs_daemon_close(NULL) will crash...

Also the preferred interface these days is just xs_open/close. The other
variants are deprecated.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel