WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH net-next 4/5] xen: convert to 64 bit stats interf

On Tue, 21 Jun 2011 15:05:54 +0100
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> On Mon, 2011-06-20 at 21:35 +0100, Stephen Hemminger wrote:
> > Convert xen driver to 64 bit statistics interface.
> > Use stats_sync to ensure that 64 bit update is read atomically
> > on 32 bit platform. Put hot statistics into per-cpu table.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
> 
> Thanks Stephen.
> 
> > @@ -867,12 +882,13 @@ static int handle_incoming_queue(struct
> >             if (checksum_setup(dev, skb)) {
> >                     kfree_skb(skb);
> >                     packets_dropped++;
> > -                   dev->stats.rx_errors++;
> 
> Why is this dropped? We should be counting these somehow, I think.
> 
> [...]
> 
> > >From shemminger@xxxxxxxxxx Mon Jun 20 13:36:03 2011
> > Message-Id: <20110620203603.019928129@xxxxxxxxxx>
> > User-Agent: quilt/0.48-1
> > Date: Mon, 20 Jun 2011 13:35:11 -0700
> > From: Stephen Hemminger <shemminger@xxxxxxxxxx>
> > To: davem@xxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Subject: [PATCH net-next 5/5] ifb: convert to 64 bit stats
> > References: <20110620203506.363818794@xxxxxxxxxx>
> > Content-Disposition: inline; filename=ifb-stats64.patch
> > 
> > Convert input functional block device to use 64 bit stats.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
> > 
> > ---
> > v2 - add stats_sync
> > 
> > 
> > --- a/drivers/net/ifb.c     2011-06-09 14:39:25.000000000 -0700
> > +++ b/drivers/net/ifb.c     2011-06-20 13:30:30.135992612 -0700
> 
> This entire patch was appended in the mail I got -- something up with
> your scripting?

Bad mbox file to quilt, merged two patches

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel