Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging

Philipp Hahn writes ("Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 
debugging"):
> Am Dienstag 21 Juni 2011 16:29:20 schrieb Ian Jackson:
> > That should be folded into the first patch, which otherwise leaves the
> > indentation wrong.
> 
> Done. I submitted it as an extra patch only for simplifying review of the 
> additional implementation.

Thanks, but we have tools which can suppress whitespace changes when
showing us diffs :-).

> > Also, you to add a Signed-off-by line to your patch to signify its
> > copyright status (see below).
> 
> The original patch already contained the Signed-off-line, since I
> knew you (or somebody else) would be asking for it ;-) If more is
> needed, please ask again.

Sorry, I must have missed that.

But I'm afraid your patch doesn't apply cleanly to xen-unstable tip:

patching file tools/blktap2/drivers/tapdisk2.c
Hunk #1 FAILED at 402.
Hunk #2 FAILED at 411.
Hunk #3 succeeded at 72 (offset -359 lines).
Hunk #4 FAILED at 83.
3 out of 4 hunks FAILED -- saving rejects to file 
tools/blktap2/drivers/tapdisk2.c.rej

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH V4] libxl, Introduce a QMP client, Ian Jackson

Next by Date:

Re: [Xen-devel] [PATCH] tools/libxl: remove O_CLOEXEC in xl_cmdimpl.c, Christoph Egger

Previous by Thread:

Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging, Philipp Hahn

Next by Thread:

Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging, Philipp Hahn

Indexes:

[Date] [Thread] [Top] [All Lists]