Re: [Xen-devel] [PATCH V4] libxl, Introduce a QMP client

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2011-06-20 at 15:50 +0100, Ian Jackson wrote:
> 
> > +static struct {
> > +    const char *name;
> > +    message_type_e type;
> > +} member_name_to_message_type[] = {
> > +    { "QMP", QMP_QMP },
> > +    { "return", QMP_RETURN },
> > +    { "error", QMP_ERROR },
> > +    { "event", QMP_EVENT },
> > +    { "", QMP_ANY },
> > +};
> 
> If we do need to define these, we should use a libxl idl enum (with
> Ian Campbell's string-mapping-generation patch which I will apply
> shortly. 

Just to note that this is enum is only used internally, using the IDL as
is would make it public... It'd be relatively easy to allow for internal
types in the IDL but I'm not sure if we want to? I think if we did I'd
be tempted to add a separate libxl_internal.idl generating (using the
same generator) _libxl_types_internal.[ch] etc.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel