WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [linux-2.6.39.x for xen] tmem: self-ballooning a

To: Daniel Kiper <dkiper@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [linux-2.6.39.x for xen] tmem: self-ballooning and frontswap-selfshrinking
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 14 Jun 2011 10:15:58 +0100
Cc: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "JBeulich@xxxxxxxxxx" <JBeulich@xxxxxxxxxx>, Dushmanta Mohapatra <dmpatra@xxxxxxxxx>
Delivery-date: Tue, 14 Jun 2011 02:16:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110609172157.GA23592@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <292df482-2d4c-4a4f-b5f4-4c808692156e@default> <20110609172157.GA23592@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-06-09 at 18:21 +0100, Daniel Kiper wrote:
> On Mon, Jun 06, 2011 at 03:12:28PM -0700, Dan Magenheimer wrote:
> 
> [...]
> 
> > +static void selfballoon_process(struct work_struct *work)
> > +{
> > +   extern unsigned long vm_get_committed_as(void);
> > +   unsigned long cur_pages, goal_pages, tgt_pages;
> > +   int reset_timer = 0;
> > +
> > +   if (balloon_stats.selfballooning_enabled) {
> > +           tgt_pages = cur_pages = totalram_pages;
> 
> tgt_pages = cur_pages = balloon_stats.current_pages;

Linux coding style prefers to avoid these multiple assignments. It
favours e.g.
        tgt_pages = balloon_stats.current_pages;
        cur_pages = balloon_stats.current_pages;
etc.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel