RE: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability

To:	Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject:	RE: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure
From:	"Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date:	Fri, 3 Jun 2011 16:25:32 +0800
Accept-language:	en-US
Acceptlanguage:	en-US
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Delivery-date:	Fri, 03 Jun 2011 01:27:29 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20110602150752.GP5098@xxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<patchbomb.1307005033@xxxxxxxxxxxxxxxxxxxx> <ee55fa0471a6b72569b5.1307005053@xxxxxxxxxxxxxxxxxxxx> <20110602150752.GP5098@xxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcwhNuv9y/BnOC4zTHuUqp/NqWx18gAkMuuQ
Thread-topic:	[Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure

> 
> At 16:57 +0800 on 02 Jun (1307033853), Eddie Dong wrote:
> > +    case MSR_IA32_VMX_PINBASED_CTLS:
> > +#define REMOVED_PIN_CONTROL_CAP (PIN_BASED_PREEMPT_TIMER)
> > +        rdmsr(msr, eax, edx);
> > +        data = edx;
> > +        data = (data << 32) | eax;
> > +        break;
> 
> You don't actually mask the value here.

Fixed. 

> 
> BTW, I don't really like defining all these REMOVED_* macros, each
> of which is used only once a few lines from the definition (here and
> elsewhere in the series).  It just adds clutter for no benefit.

OK, removed to be in code itself.

Thx, Eddie

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] Re: [PATCH 4.0-testing] tools/hotplug/Linux: LSB header modify, Ian Campbell

Next by Date:

[Xen-users] Re: [Xen-devel] Access domU from dom0, Ian Campbell

Previous by Thread:

RE: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure, Dong, Eddie

Next by Thread:

[Xen-devel] [PATCH 05 of 20] Emulation of guest VMXON/OFF instruction, Eddie Dong

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

RE: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure