WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] libxl: basic support for virtio disk

Wei Liu writes ("[Xen-devel] Re: [PATCH] libxl: basic support for virtio disk"):
> Revised patch.
> 
> Add code in libxl__device_disk_string_of_backend.
> 
> Upper limit of virtio disk follows scsi.

I'm not sure what you mean here.  Do you mean that Linux only supports
as many virtio disks as it supports scsi disks ?  Is this a
fundamental limitation of the virtio protocol ?

> +                else if (strncmp(disks[i].vdev, "vd", 2) == 0)
> +                    drive = libxl__sprintf
> +                        (gc, 
> "file=%s,if=virtio,index=%d,media=disk,format=%s",
> +                         disks[i].pdev_path, disk, format);

Maybe I'm missing something but this seems not to use the partition
number at all ?

The existing code seems rather broken TBH.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel