This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] libxl: basic support for virtio disk

On Fri, May 27, 2011 at 8:26 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> I think you should print an error here, because we should never reach
> this point.

You mean we should never setup Xenstore entries for a virtio disk?

> Also I think you need to add the LIBXL_DISK_BACKEND_NONE case to
> libxl_device_disk_del, libxl_device_disk_local_attach and
> libxl_string_to_backend.

I notice those functions. But I haven't decide what to add to them.
But if we are not storing any information in Xenstore for virtio disk,
the modification to these functions should be minimal.

> The rest of the patch looks good even though disk hotplug is not handled
> (but we need QMP support in libxl for that, I know that some patches are
> being worked to add it as we speak).

Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name

Xen-devel mailing list