This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: Deal with stdarg.h and -nostdinc

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: Deal with stdarg.h and -nostdinc
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Fri, 27 May 2011 09:47:53 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 27 May 2011 01:06:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19934.31685.537152.784058@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DDE698B.1060302@xxxxxxx> <19934.31685.537152.784058@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; NetBSD amd64; en-US; rv: Gecko/20110523 Lightning/1.0b3pre Thunderbird/3.1.10
On 05/26/11 18:11, Ian Jackson wrote:
Christoph Egger writes ("[Xen-devel] [PATCH] xen: Deal with stdarg.h and 
For compiling the xen kernel we use -nostdinc which means
we don't want to rely on any external headers.
That also counts for stdarg.h.

Right, OK, but:

Use the external header when we compile the tools.
Adapt libelf-loader.c which is compiled in the kernel
and with the tools.

+#include "../../include/xen/stdarg.h"

Firstly, is this correct for all uses of libelf-loader ?  This file is
compiled both for use inside Xen and for use on the host.  In the
latter case it /should/ use the system's stdarg.h.

This is exactly what happens in conjunction with the other diff.
In the first case there is __XEN__ defined and in the latter case
__XEN__ is *not* defined.

Also, this kind of relative path should not be necessary.  The
relevant files should be on the include path.

I tried <xen/stdarg.h> but then compiling the tools failed.

So I think this should be fixed by arranging that your new stdarg.h is
on the relevant include path, not by changing the .c file.


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>