WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/2] libxc: enabling emulated MSI injection

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2] libxc: enabling emulated MSI injection
From: Wei Liu <liuw@xxxxxxxxx>
Date: Thu, 26 May 2011 20:56:09 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 26 May 2011 05:57:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110526123452.GA3386@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTi=PDEZzOOXsmzYVfuCnNf9uaOt_EQ@xxxxxxxxxxxxxx> <20110526123452.GA3386@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, May 26, 2011 at 8:34 PM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, May 26, 2011 at 11:09:43AM +0800, Wei Liu wrote:
>> commit 67038b5b18096b3bdcda7fe393d1be6a91dc75a6
>> Author: Wei Liu <liuw@xxxxxxxxx>
>> Date:   Thu May 26 10:27:41 2011 +0800
>>
>>     libxc: add new operation in HVMOP to deliver emulated MSI.
>
> What is the purpose of this call?
>>
>>     Signed-off-by: Wei Liu <liuw@xxxxxxxxx>
>>
>> diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c
>> index b87bbc0..38af397 100644
>> --- a/tools/libxc/xc_misc.c
>> +++ b/tools/libxc/xc_misc.c
>> @@ -417,6 +417,35 @@ int xc_hvm_set_pci_link_route(
>>      return rc;
>>  }
>>
>> +int xc_hvm_inj_msi(
>> +    xc_interface *xch, domid_t dom, uint64_t addr, uint32_t data)
>> +{
>> +    DECLARE_HYPERCALL;
>> +    DECLARE_HYPERCALL_BUFFER(struct xen_hvm_inj_msi, arg);
>> +    int rc;
>> +
>> +    arg = xc_hypercall_buffer_alloc(xch, arg, sizeof(*arg));
>> +    if ( arg == NULL )
>> +    {
>> +        PERROR("Could not allocate memory for xc_hvm_inj_msi hypercall");
>> +        return -1;
>> +    }
>> +
>> +    hypercall.op     = __HYPERVISOR_hvm_op;
>> +    hypercall.arg[0] = HVMOP_inj_msi;
>> +    hypercall.arg[1] = HYPERCALL_BUFFER_AS_ARG(arg);
>> +
>> +    arg->domid = dom;
>> +    arg->addr  = addr;
>> +    arg->data  = data;
>
> Shouldn't those be done before you make the HYPERCALL_BUFFER_AS_ARG
> in case they get bounced?
>

Hmm... I didn't think that far.

I just copy-and-edit from a previous hypercall. I think that should be OK then.

>> +
>> +    rc = do_xen_hypercall(xch, &hypercall);
>> +
>> +    xc_hypercall_buffer_free(xch, arg);
>> +
>> +    return rc;
>> +}
>> +
>>  int xc_hvm_track_dirty_vram(
>>      xc_interface *xch, domid_t dom,
>>      uint64_t first_pfn, uint64_t nr,
>> diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h
>> index 9a4355f..2442c84 100644
>> --- a/tools/libxc/xenctrl.h
>> +++ b/tools/libxc/xenctrl.h
>> @@ -1387,6 +1387,8 @@ int xc_hvm_set_isa_irq_level(
>>  int xc_hvm_set_pci_link_route(
>>      xc_interface *xch, domid_t dom, uint8_t link, uint8_t isa_irq);
>>
>> +int xc_hvm_inj_msi(
>> +    xc_interface *xch, domid_t dom, uint64_t addr, uint32_t data);
>>
>>  /*
>>   * Track dirty bit changes in the VRAM area
>>
>> --
>> Best regards
>> Wei Liu
>> Twitter: @iliuw
>> Site: http://liuw.name
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>



-- 
Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel