| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH V3 2/2] mm: Extend memory hotplug API to allow me
|
To: |
Daniel Kiper <dkiper@xxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH V3 2/2] mm: Extend memory hotplug API to allow memory hotplug in virtual machines |
|
From: |
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|
Date: |
Thu, 19 May 2011 16:01:43 -0700 |
|
Cc: |
jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, haicheng.li@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx, dave@xxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, David Rientjes <rientjes@xxxxxxxxxx>, fengguang.wu@xxxxxxxxx, wdauchy@xxxxxxxxx |
|
Delivery-date: |
Thu, 19 May 2011 16:03:50 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20110519204509.GD27202@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20110517213858.GC30232@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1105182026390.20651@xxxxxxxxxxxxxxxxxxxxxxxxx> <20110519204509.GD27202@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 19 May 2011 22:45:09 +0200
Daniel Kiper <dkiper@xxxxxxxxxxxx> wrote:
> On Wed, May 18, 2011 at 08:36:02PM -0700, David Rientjes wrote:
> > On Tue, 17 May 2011, Daniel Kiper wrote:
> >
> > > This patch contains online_page_callback and apropriate functions for
> > > setting/restoring online page callbacks. It allows to do some machine
> > > specific tasks during online page stage which is required to implement
> > > memory hotplug in virtual machines. Additionally,
> > > __online_page_set_limits(),
> > > __online_page_increment_counters() and __online_page_free() function
> > > was added to ease generic hotplug operation.
> >
> > There are several issues with this.
> >
> > First, this is completely racy and only allows one global callback to be
> > in use at a time without looping, which is probably why you had to pass an
>
> One callback is allowed by design. Currently I do not see
> any real usage for more than one callback.
I'd suggest that you try using the notifier.h tools here and remove the
restriction. Sure, we may never use the capability but I expect the
code will look nice and simple and once it's done, it's done.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home