WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [tip:x86/irq] x86: Don't unmask disabled irqs when migrating

To: linux-tip-commits@xxxxxxxxxxxxxxx
Subject: [Xen-devel] [tip:x86/irq] x86: Don't unmask disabled irqs when migrating them
From: "tip-bot for Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Thu, 19 May 2011 12:55:29 GMT
Cc: kevin.tian@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxx, fengzhe.zhang@xxxxxxxxx, JBeulich@xxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, tglx@xxxxxxxxxxxxx
Delivery-date: Thu, 19 May 2011 05:57:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
Git-commit-id: 983bbf1af0664b78689612b247acb514300f62c7
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: linux-kernel@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, fengzhe.zhang@xxxxxxxxx, Ian.Campbell@xxxxxxxxxx, JBeulich@xxxxxxxxxx, kevin.tian@xxxxxxxxx, tglx@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Robot-id: <tip-bot.git.kernel.org>
Robot-unsubscribe: Contact <mailto:hpa@xxxxxxxxxx> to get blacklisted from these emails
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Commit-ID:  983bbf1af0664b78689612b247acb514300f62c7
Gitweb:     http://git.kernel.org/tip/983bbf1af0664b78689612b247acb514300f62c7
Author:     Tian, Kevin <kevin.tian@xxxxxxxxx>
AuthorDate: Fri, 6 May 2011 14:43:56 +0800
Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Thu, 19 May 2011 14:51:08 +0200

x86: Don't unmask disabled irqs when migrating them

It doesn't make sense to unconditionally unmask a disabled irq when
migrating it from offlined cpu to another. If the irq triggers then it
will be disabled in the interrupt handler anyway. So we can just avoid
unmasking it.

[ tglx: Made masking unconditional again and fixed the changelog ]

Signed-off-by: Fengzhe Zhang <fengzhe.zhang@xxxxxxxxx>
Signed-off-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Cc: Jan Beulich <JBeulich@xxxxxxxxxx>
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Link: 
http://lkml.kernel.org/r/%3C625BA99ED14B2D499DC4E29D8138F1505C8ED7F7E3%40shsmsx502.ccr.corp.intel.com%3E
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

---
 arch/x86/kernel/irq.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 544efe2..6c0802e 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -276,7 +276,8 @@ void fixup_irqs(void)
                else if (!(warned++))
                        set_affinity = 0;
 
-               if (!irqd_can_move_in_process_context(data) && chip->irq_unmask)
+               if (!irqd_can_move_in_process_context(data) &&
+                   !irqd_irq_disabled(data) && chip->irq_unmask)
                        chip->irq_unmask(data);
 
                raw_spin_unlock(&desc->lock);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [tip:x86/irq] x86: Don't unmask disabled irqs when migrating them, tip-bot for Tian, Kevin <=