WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] nestedsvm: fix shadow-on-hap

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] nestedsvm: fix shadow-on-hap
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Wed, 11 May 2011 17:11:09 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 11 May 2011 09:11:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DCA8E9F.3080706@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DCA86AF.6050207@xxxxxxx> <4DCA8E9F.3080706@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
At 14:26 +0100 on 11 May (1305124015), Christoph Egger wrote:
> diff -r 0c60c61ff836 xen/arch/x86/hvm/svm/entry.S
> --- a/xen/arch/x86/hvm/svm/entry.S    Tue May 10 11:42:02 2011 +0200
> +++ b/xen/arch/x86/hvm/svm/entry.S    Wed May 11 15:24:00 2011 +0200
> @@ -65,12 +65,16 @@ ENTRY(svm_asm_do_resume)
>          testl $~0,(r(dx),r(ax),1)
>          jnz  .Lsvm_process_softirqs
>  
> +        testb $0, VCPU_nsvm_hap_enabled(r(bx))
> +        jz  .Lsvm_asid_handle
> +        
>          mov  VCPU_nhvm_p2m(r(bx)),r(ax)
>          test r(ax),r(ax)
>          sete %al
>          andb VCPU_nhvm_guestmode(r(bx)),%al
>          jnz  .Lsvm_nsvm_no_p2m
>  
> +.Lsvm_asid_handle:

It would be neater to AND nsvm_hap_enabled into the no-p2m calculation
rather than have another jump, but unless you feel like fixing that, 
this and your other 3 recent nested-SVM patches are

Acked-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>