Re: [Xen-devel] Re: non-contiguous allocations

To:	Keir Fraser <keir.xen@xxxxxxxxx>
Subject:	Re: [Xen-devel] Re: non-contiguous allocations
From:	Olaf Hering <olaf@xxxxxxxxx>
Date:	Mon, 9 May 2011 14:43:14 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Mon, 09 May 2011 05:43:49 -0700
Dkim-signature:	v=1; a=rsa-sha1; c=relaxed/relaxed; t=1304944994; l=801; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=TbLWmIqwx1HGVl/KeBhey1JXDKE=; b=r9VlQ1rzf99Dl4G46LHDk2zlumNdEwdxLnosXD3hKBAydt2+Hvcgi/eRjdAuBRRmnLR aArIR7hVeoi36JFj7+OdgahFgnhGCKqnv3ZusmiKtZ0Ap86KUm2Jelbes81BZZcjh59L5 J5+tV7xX4Ue0HNJrL9cm4+f6OrML+R3Akw0=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<C9EA00AE.176D4%keir.xen@xxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20110506181234.GA24767@xxxxxxxxx> <C9EA00AE.176D4%keir.xen@xxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.21 (2010-09-15)

On Fri, May 06, Keir Fraser wrote:

> On 06/05/2011 19:12, "Olaf Hering" <olaf@xxxxxxxxx> wrote:
> >  From which pool should the per-cpu tracebuffers
> > get allocated?  alloc_domheap_page() wants a domain, so I think thats
> > the wrong interface.
> 
> Yes, sticking with alloc_xenheap_pages() is good.

Another question:
alloc_trace_bufs() calls alloc_xenheap_pages(0, MEMF_bits(32 + PAGE_SHIFT));

MEMF_bits() is not used in the i386 codepath in alloc_heap_pages(),
unless I miss something.
Otherwise alloc_domheap_pages() is called, which passes BITS_PER_LONG
instead of 32 to domain_clamp_alloc_bitsize().

Is the hardcoded 32+PAGE_SHIFT required in some way, or could I just use
the alloc_xenheap_page() macro and let alloc_domheap_pages() deal with
allocation details?

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Re: non-contiguous allocations