[Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV dom

To:	Wei Liu <liuw@xxxxxxxxx>, Xen Devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain
From:	Takeshi HASEGAWA <hasegaw@xxxxxxxxx>
Date:	Sun, 8 May 2011 20:26:16 +0900
Cc:	Anthony PERARD <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date:	Sun, 08 May 2011 04:26:57 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=70OhVcaeK6pQBg3X4KDILHn/GTfRH/uP2sXf2lrRv+Y=; b=nAz3r5OFXTWbzqJ3efHHRdqwDxMLIXEWyTKa1bYUBl5j7w201z53zbibU1vwMotVD/ b/IKhzxJ89LN0eLBjzmXkxd1rUKUXvcitx2HX6WPGle+V6H/vCuEzTsrBOstFm1V6Ixt pDLZJobgK8YjUFcjNUdSsBLqDme+5B6EBzot8=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=p/1Vt3lwXDp4hg6WChd4zi6nItiVGtp06x+6a6lIqNNxvycROodtAav3JSUWPDeYCn R4nEkHkEMs7R4WXPABgpfieRvewGDiNuleUadTDysmIbJ9+sJQ2vNdDqq4SbEvUIGOzi moJ9T7ao7bqkRtTr8YMA8seFESTDolV6085I4=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<BANLkTin2+FtCL4-L1ZsZUov2153HiXSq7w@xxxxxxxxxxxxxx> <BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@xxxxxxxxxxxxxx> <BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

My patch threats virtio block devices with same manner with xvd, sd, and hd.
Though, I need to discuss with xen developpers whether the vbd number
assignment is reasonable or not.

I guess blktap and blkback will never handle virto block device, so assigning
(reserving) the whole range of 2 << 28 for virtio block vbd may be more better.

Actually virtio is not Xen's VBD, so vbd number is not mandatory to work.
However, I believe this approach makes virtio block manageable
in same way as xvd and others.

I am looking forward for xen developpers' opinions.

Thanks,
Takeshi

2011/05/08 14:25 "Wei Liu" <liuw@xxxxxxxxx>:
> On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@xxxxxxxxx> wrote:
>> Thanks, I just started working on VirtIO block support yesterday.
>>
>> I was trying to add support to parse_disk_config() so that we can
>> specify "-if" option in the config file.
>>
>> I'm wondering which approach is better -- configure through
>> device_virtdisk_matches() or parse_disk_config() .
>>
>> Any suggestions?
>
> It seems that Takeshi's approach is better.
>
> I should follow libxl's conventions.
>
> --
> Best regards
> Wei Liu
> Twitter: @iliuw
> Site: http://liuw.name

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain