| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH 1/4] mm: Remove dependency on CONFIG_FLATMEM from
|
To: |
Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 1/4] mm: Remove dependency on CONFIG_FLATMEM from online_page() |
|
From: |
Daniel Kiper <dkiper@xxxxxxxxxxxx> |
|
Date: |
Tue, 3 May 2011 00:18:57 +0200 |
|
Cc: |
jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, haicheng.li@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, rientjes@xxxxxxxxxx, andi.kleen@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, Daniel Kiper <dkiper@xxxxxxxxxxxx>, wdauchy@xxxxxxxxx |
|
Delivery-date: |
Mon, 02 May 2011 15:20:57 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1304371504.30823.45.camel@nimitz> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20110502211915.GB4623@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1304371504.30823.45.camel@nimitz> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.3.28i |
On Mon, May 02, 2011 at 02:25:04PM -0700, Dave Hansen wrote:
> On Mon, 2011-05-02 at 23:19 +0200, Daniel Kiper wrote:
> > Memory hotplug code strictly depends on CONFIG_SPARSEMEM.
> > It means that code depending on CONFIG_FLATMEM in online_page()
> > is never compiled. Remove it because it is not needed anymore.
>
> It's subtle, but I don't think that's true. We had another hotplug mode
> for x86_64 before folks were comfortable turning SPARSEMEM on for the
> whole architecture. It was quite possible to have memory hotplug
> without sparsemem in that case. I think Keith Mannthey did some of that
> code if I remember right.
>
> But, I'm not sure how much of that stayed in distros versus made it
> upstream. In any case, you might want to chase down the
> X86_64_ACPI_NUMA bit to make sure it can't be used with FLATMEM ever.
>
> config MEMORY_HOTPLUG
> bool "Allow for memory hot-add"
> depends on SPARSEMEM || X86_64_ACPI_NUMA
> depends on HOTPLUG && ARCH_ENABLE_MEMORY_HOTPLUG
> depends on (IA64 || X86 || PPC_BOOK3S_64 || SUPERH || S390)
IIRC some time ago it was possible to enable memory hotplug with
CONFIG_FLATMEM. That is why I looked for any dependencies of memory
hoplug code on CONFIG_FLATMEM in current Linux Kernel source. I could
not find anything and that is why I published this patch. However,
maybe I missed something.
Daniel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home